-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Upgrade guava version to 33.4.8 #12219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
According to https://issuetracker.google.com/issues/342522142#comment8 (Jun 6, 2024):
|
@shivaspeaks PTAL |
We're trying to get a release made (v1.74.0). Once it is made, we'll look at bumping the dependency versions. |
We should look at getting this in, as it also fixes the errorprone-annotations problem. We should double-check whether the D8 NPE also is triggered for our users as well, as then we can point them to the workaround in case they are impacted. (Although that's not strictly necessary.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I confirmed that the NPE error propagates to our examples, so it is necessary to update them. We'll need to notify users in our release notes.
Thank you so much!
(FYI: nobody should need to wait for us to upgrade dependencies like Guava. Newer versions of dependencies should generally be fine. We only discourage downgrading dependencies.) |
You are welcome. |
#12215
Guava seems to call a deprecated sun.misc.Unsafe::objectFieldOffset method which might be removed in a future JDK release.
There are still a few things to do for -android versions, which are tracked in google/guava#7742,
see details at google/guava#7811